Action Cable: JavaScript test updates #27123

Merged
merged 2 commits into from Nov 21, 2016

Projects

None yet

3 participants

@javan
Member
javan commented Nov 20, 2016
@javan javan added the actioncable label Nov 20, 2016
@maclover7

Overall big 👍 👍 to adding more tests for Action Cable's JS! If possible, can you make each of the test's names more descriptive? While I was reading through, it was a little tough to determine what each of the tests was doing 😬

+
+ broadcast(message_type: "confirmation")
+
+
@maclover7
maclover7 Nov 20, 2016 Member

too many empty lines here? 😬

+ broadcast(message_type: "confirmation")
+
+
+broadcast = (data = {}, callback) ->
@maclover7
maclover7 Nov 20, 2016 Member

Might be a bit early, but should we extract the broadcast function out to where the rest of the "helper" functions are?

@maclover7 maclover7 self-assigned this Nov 20, 2016
@javan
Member
javan commented Nov 21, 2016

@maclover7 done and done

javan added some commits Nov 20, 2016
@javan javan Bump Blade and its Sauce Labs plugin to fix tunnel shutdown and relat… 6f30cb3
@javan javan Add more Action Cable JavaScript tests
7083fa2
@kaspth kaspth merged commit bb2a832 into rails:master Nov 21, 2016

2 checks passed

codeclimate Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kaspth
Member
kaspth commented Nov 21, 2016

Nice!

@javan javan deleted the javan:actioncable/js-test-updates branch Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment