Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing update_all and delete_all when chained with left_joins #27193

Merged
merged 1 commit into from Nov 28, 2016
Merged

fixing update_all and delete_all when chained with left_joins #27193

merged 1 commit into from Nov 28, 2016

Conversation

@plentz
Copy link
Contributor

@plentz plentz commented Nov 27, 2016

fixes #27192

@rails-bot
Copy link

@rails-bot rails-bot commented Nov 27, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@spastorino spastorino merged commit 0825107 into rails:master Nov 28, 2016
2 checks passed
2 checks passed
codeclimate Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@JotaSe
Copy link

@JotaSe JotaSe commented Sep 26, 2017

@khiav223577
Copy link

@khiav223577 khiav223577 commented Jun 22, 2019

Will it be merged into 5.0.x?
It still be an issue in 5.0.7.2:
https://github.com/rails/rails/blob/v5.0.7.2/activerecord/lib/active_record/relation.rb

khiav223577 pushed a commit to khiav223577/left_joins that referenced this pull request Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

7 participants