New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to custom content type when setting mailer body #27227

Merged
merged 5 commits into from Jan 6, 2017

Conversation

Projects
None yet
6 participants
@MQuy
Contributor

MQuy commented Nov 30, 2016

Summary

Allow to custom content-type in case of setting headers[:body] and attachments

attachments[:rails] = xxx
mail(
  body: "<html><body>Hello rails</body></html>",
  content_type: "text/html"
)
# => content_type is now text/hml
@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Nov 30, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

rails-bot commented Nov 30, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@sgrif

This comment has been minimized.

Show comment
Hide comment
@sgrif

sgrif Nov 30, 2016

Member

Thank you for the pull request. Can you add documentation and a changelog entry?

Member

sgrif commented Nov 30, 2016

Thank you for the pull request. Can you add documentation and a changelog entry?

@MQuy

This comment has been minimized.

Show comment
Hide comment
@MQuy

MQuy Dec 1, 2016

Contributor

@sgrif thank for your feedback, I added changelog and release note.
About document, I wonder where should I add because it is just the option which we miss to check in case of attachment and header body for mailer

Contributor

MQuy commented Dec 1, 2016

@sgrif thank for your feedback, I added changelog and release note.
About document, I wonder where should I add because it is just the option which we miss to check in case of attachment and header body for mailer

@sgrif

This comment has been minimized.

Show comment
Hide comment
@sgrif

sgrif Dec 5, 2016

Member

I would document it on the mail method

Member

sgrif commented Dec 5, 2016

I would document it on the mail method

@MQuy

This comment has been minimized.

Show comment
Hide comment
@MQuy

MQuy Dec 6, 2016

Contributor

@sgrif thank for your feedback, I just add documentation for mail method :)

Contributor

MQuy commented Dec 6, 2016

@sgrif thank for your feedback, I just add documentation for mail method :)

@MQuy

This comment has been minimized.

Show comment
Hide comment
@MQuy

MQuy Jan 6, 2017

Contributor

@sgrif i wonder is there anything lefts should i do?

Contributor

MQuy commented Jan 6, 2017

@sgrif i wonder is there anything lefts should i do?

@MQuy

This comment has been minimized.

Show comment
Hide comment
@MQuy

MQuy Jan 6, 2017

Contributor

@rafaelfranca thank for your suggestion 🙇, please let's me know if is there anything else need to be improved :D

Contributor

MQuy commented Jan 6, 2017

@rafaelfranca thank for your suggestion 🙇, please let's me know if is there anything else need to be improved :D

@rafaelfranca rafaelfranca merged commit f091bd6 into rails:master Jan 6, 2017

2 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

rafaelfranca added a commit that referenced this pull request Jan 6, 2017

Merge pull request #27227 from MQuy/allow-custom-content-type-in-mail…
…-body

Allow to custom content type when setting mailer body

@maclover7 maclover7 removed the needs work label Jan 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment