Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix association scope inside autosaved association callbacks #27251

Merged
merged 2 commits into from Dec 6, 2016

Conversation

ebeigarts
Copy link
Contributor

@ebeigarts ebeigarts commented Dec 2, 2016

This pull request fixes has many scope in autosave after_save callbacks.
This problem is also present in 4.2.x.

class Post < ActiveRecord::Base
  has_many :comments, inverse_of: :post
end

class Comment < ActiveRecord::Base
  belongs_to :post

  after_save do
    puts post.comments.count #=> expected 1, got: 0
    puts post.comments.reload.count #=> expected: 1, got: 1
  end
end

post = Post.new
post.comments.build
post.save!

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@ebeigarts ebeigarts changed the title Reset association scope inside autosaved associations Fix association scope inside autosaved association callbacks Dec 2, 2016
@sgrif
Copy link
Contributor

sgrif commented Dec 5, 2016

Can you change the test to not use the anonymous_class option? I would prefer to exercise this through only public API

@ebeigarts
Copy link
Contributor Author

@sgrif fixed, does it look good now?

@sgrif sgrif merged commit 09b2e29 into rails:master Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants