Basic --webpack delegation to new webpacker gem #27288

Merged
merged 3 commits into from Dec 9, 2016

Projects

None yet

4 participants

@dhh
Member
dhh commented Dec 7, 2016 edited

Fair warning: This is early stage work.

  • Make Yarn the default for new apps
  • Polish the Webpacker gem a lot more

This works with https://github.com/rails/webpacker

@dhh dhh Basic --webpack delegation to new webpacker gem
407fd84
@maclover7 maclover7 added the railties label Dec 7, 2016
@dhh dhh added this to the 5.1.0 milestone Dec 7, 2016
dhh added some commits Dec 8, 2016
@dhh dhh Merge branch 'master' into webpacker
bea2e85
@dhh dhh Merge branch 'master' into webpacker
0c7af37
@dhh dhh merged commit 8c947eb into master Dec 9, 2016

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
codeclimate no new or fixed issues
Details
@dhh dhh deleted the webpacker branch Dec 9, 2016
@guilleiguaran
Member

❤️ ❤️ ❤️ ❤️ ❤️

@y-yagi y-yagi added a commit to y-yagi/rails that referenced this pull request Dec 10, 2016
@y-yagi y-yagi gemfile entry method need to return an empty array rather than nil
Follow up to #27288
da82000
@y-yagi y-yagi added a commit to y-yagi/rails that referenced this pull request Dec 10, 2016
@y-yagi y-yagi gemfile entry method need to return an empty array rather than nil
This fixes the following error when executing rails new command.

```
(erb):9:in `block in template': undefined method `comment' for nil:NilClass (NoMethodError)
```

Follow up to #27288
93c66ed
@dhh dhh added a commit that referenced this pull request Dec 10, 2016
@y-yagi @dhh y-yagi + dhh gemfile entry method need to return an empty array rather than nil (#…
…27318)

This fixes the following error when executing rails new command.

```
(erb):9:in `block in template': undefined method `comment' for nil:NilClass (NoMethodError)
```

Follow up to #27288
c16296c
@m5o m5o referenced this pull request in ytbryan/vuejs Dec 11, 2016
Closed

vuejs integration with rails/webpacker #2

@aguynamedben
Contributor

👏 Zomg yes I would love to see Rails take a more "here's the official recommended way to use Webpack/ES6/npm/React/etc.". Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment