Basic --webpack delegation to new webpacker gem #27288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 7, 2016
|
❤️ ❤️ ❤️ ❤️ ❤️ |
y-yagi
added a commit
to y-yagi/rails
that referenced
this pull request
Dec 10, 2016
This fixes the following error when executing rails new command. ``` (erb):9:in `block in template': undefined method `comment' for nil:NilClass (NoMethodError) ``` Follow up to rails#27288
|
👏 Zomg yes I would love to see Rails take a more "here's the official recommended way to use Webpack/ES6/npm/React/etc.". Thanks!!! |
ttanimichi
added a commit
to ttanimichi/rails
that referenced
this pull request
Dec 4, 2017
We probably don't have any tests for the `--webpack` option. related: rails#27288
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fair warning: This is early stage work.
This works with https://github.com/rails/webpacker