Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic --webpack delegation to new webpacker gem #27288

Merged
merged 3 commits into from Dec 9, 2016
Merged

Basic --webpack delegation to new webpacker gem #27288

merged 3 commits into from Dec 9, 2016

Conversation

@dhh
Copy link
Member

@dhh dhh commented Dec 7, 2016

Fair warning: This is early stage work.

  • Make Yarn the default for new apps
  • Polish the Webpacker gem a lot more

This works with https://github.com/rails/webpacker

@dhh dhh merged commit 8c947eb into master Dec 9, 2016
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
codeclimate no new or fixed issues
Details
@dhh dhh deleted the webpacker branch Dec 9, 2016
@guilleiguaran
Copy link
Member

@guilleiguaran guilleiguaran commented Dec 9, 2016

❤️ ❤️ ❤️ ❤️ ❤️

y-yagi added a commit to y-yagi/rails that referenced this pull request Dec 10, 2016
This fixes the following error when executing rails new command.

```
(erb):9:in `block in template': undefined method `comment' for nil:NilClass (NoMethodError)
```

Follow up to rails#27288
dhh added a commit that referenced this pull request Dec 10, 2016
…27318)

This fixes the following error when executing rails new command.

```
(erb):9:in `block in template': undefined method `comment' for nil:NilClass (NoMethodError)
```

Follow up to #27288
@aguynamedben
Copy link
Contributor

@aguynamedben aguynamedben commented Dec 12, 2016

👏 Zomg yes I would love to see Rails take a more "here's the official recommended way to use Webpack/ES6/npm/React/etc.". Thanks!!!

ttanimichi added a commit to ttanimichi/rails that referenced this pull request Dec 4, 2017
We probably don't have any tests for the `--webpack` option.
related: rails#27288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.