Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Coders::YAMLColumn#dump should raise an error #2737

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

gutenye commented Aug 29, 2011

class Foo < ActiveRerocd::Base
  serialize :posts, Array
end

foo = Foo.new
foo.posts = "a"
foo.save # It doen't raise an error.

foo.posts # It raises ActiveRecord::SerializationTypeMismatch

It's strange, when you save the data, it doesn't raise any error, but when we get the data, it raises an error.

so, in #dump, we should raise an error, too

Owner

tenderlove commented Aug 29, 2011

Tests?

Contributor

gutenye commented Aug 30, 2011

sorry, I've add it now.

Is this ok for merging to master now?

Owner

tenderlove commented Mar 23, 2012

Ya, I think it's fine. Need to rebase these commits though. :-/

@drogus drogus closed this in 9637de6 Mar 26, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment