Join GitHub today
Previously when an exception occurred for a SJR request, then no error was shown. You had to check the server log, or request information via browser's web development tools.
This PRs shows backend exceptions for SJR requests immediately in the alert dialog.
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @matthewd (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.
Please see the contribution instructions for more information.
@mrhead This seems like an excellent change to make SJR easier to use and debug.
I have been maintaining a gem called BetterSJR which aims to do just that. If this change does not make it in to Rails Core, I'd welcome a pull request to the gem to incorporate this functionality there.
Still relevant in Rails 6 (bd139a5). I like the idea behind this change but I think it could use a refactor. If we're going to change this behaviour, it should be displaying errors in the console and not a modal.