Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add channel_prefix support to AC redis/evented_redis adapters #27425
In Redis, Pub/Sub has no relation to the key space. It was made to not interfere with it on any level, including database numbers.
To avoid problems when multiple Rails applications use the same Redis instance, the redis/evented_redis subscription adapters now support a channel_prefix option (specified in cable.yml)
Other backends do not appear to have this issue.
The generated cable.yml has also been updated to reflect this change.
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.
Please see the contribution instructions for more information.
referenced this pull request
Dec 21, 2016
Thank you for the pull request. It makes sense to me. I made some minor comments in the files.
On Tue, Jan 17, 2017, 11:11 PM Rafael França ***@***.***> wrote: ***@***.**** requested changes on this pull request. Could you squash your first 6 commits in one? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#27425 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AWGp59TchMiZHaiYdLlYuW3ha5YrbyTFks5rTZECgaJpZM4LTLjs> .