New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active Record supports MySQL >= 5.1.10 #27435

Merged
merged 1 commit into from Jan 3, 2017

Conversation

Projects
None yet
5 participants
@kamipo
Member

kamipo commented Dec 22, 2016

Follow up to #25307 and #23458. Related with #27422.

We are using information_schema.referential_constraints since #25307.
The table was introduced in MySQL 5.1.10. MySQL 5.0 is too old. It is
enough to support >= 5.1.10 at least.

MySQL 5.0 GA was released in Dec 2005 and already EOL in Dec 2011.
MySQL 5.1 GA was released in Dec 2008 and already EOL in Dec 2013.

Active Record supports MySQL >= 5.1.10
Follow up to #25307 and #23458. Related with #27422.

We are using `information_schema.referential_constraints` since #25307.
The table was introduced in MySQL 5.1.10. MySQL 5.0 is too old. It is
enough to support >= 5.1.10 at least.

MySQL 5.0 GA was released in Dec 2005 and already EOL in Dec 2011.
MySQL 5.1 GA was released in Dec 2008 and already EOL in Dec 2013.
@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Dec 22, 2016

r? @sgrif

(@rails-bot has picked a reviewer for you, use r? to override)

r? @sgrif

(@rails-bot has picked a reviewer for you, use r? to override)

@matthewd

This comment has been minimized.

Show comment
Hide comment
@matthewd

matthewd Dec 22, 2016

Member

This seems fine for master, but we'll need to fix it for 5.0; we can't drop compatibility in a patch release.

Member

matthewd commented Dec 22, 2016

This seems fine for master, but we'll need to fix it for 5.0; we can't drop compatibility in a patch release.

@sgrif

This comment has been minimized.

Show comment
Hide comment
@sgrif

sgrif Jan 3, 2017

Member

Agreed. Feel free to submit a follow-up directly to 5-0-stable.

Member

sgrif commented Jan 3, 2017

Agreed. Feel free to submit a follow-up directly to 5-0-stable.

@sgrif sgrif merged commit 0d8069d into rails:master Jan 3, 2017

2 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kamipo kamipo deleted the kamipo:follow_up_25307 branch Jan 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment