Add "check_parameters" option to "current_page?" #27549
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
mpugach
force-pushed
the
consider_params_in_current_page
branch
from
1346959
to
7c0d853
Compare
mpugach
changed the title
| @@ -539,12 +542,14 @@ def current_page?(options) | |||
|
|
|||
| return false unless request.get? || request.head? | |||
|
|
|||
| strict_params ||= !options.is_a?(String) && options.try(:delete, :strict_params) | |||
There was a problem hiding this comment.
Why this line is needed? Should not the keyword argument take care of this?
There was a problem hiding this comment.
not always
def ololo(options, some_keyword: false)
puts options.inspect
puts some_keyword.inspect
end
ololo(action: :index, controller: :some, some_keyword: :tralala)
# {:action=>:index, :controller=>:some, :some_keyword=>:tralala}
# false
| @@ -530,7 +533,7 @@ def mail_to(email_address, name = nil, html_options = {}, &block) | |||
| # | |||
| # We can also pass in the symbol arguments instead of strings. | |||
| # | |||
| def current_page?(options) | |||
| def current_page?(options, strict_params: false) | |||
There was a problem hiding this comment.
Maybe check_paramters is a better name?
mpugach
force-pushed
the
consider_params_in_current_page
branch
from
7c0d853
to
cb4122d
Compare
Example: For "http://www.example.com/shop/checkout?order=desc&page=1" current_page?('http://www.example.com/shop/checkout') => true current_page?( 'http://www.example.com/shop/checkout', check_parameters: true ) => false
mpugach
force-pushed
the
consider_params_in_current_page
branch
from
cb4122d
to
13352f6
Compare
mpugach
changed the title
|
@rafaelfranca, updated |
- `check_parameters` kwargs was added to the `current_page?` method, the implementation was assuming only hashes responds to `delete`. This was causing issues when `current_page?` was called with a Active Model object - ref rails#27549 - Fixes rails#28846
Example:
For
http://www.example.com/shop/checkout?order=desc&page=1This is needed when
http://www.example.com/shop/checkoutnavigation is also present on the page. Without this option both paths are considered current.