Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix generator command for nested (namespaced) rails engine (take 2) #27605
+27
−3
Conversation
This comment has been minimized.
This comment has been minimized.
rails-bot
commented
Jan 7, 2017
|
r? @kaspth (@rails-bot has picked a reviewer for you, use r? to override) |
rails-bot
assigned
kaspth
Jan 7, 2017
maclover7
added
the
railties
label
Jan 7, 2017
chancancode
merged commit 6e5e8ba
into
rails:master
Feb 15, 2017
This comment has been minimized.
This comment has been minimized.
|
@mtsmfm thank you!! |
This comment has been minimized.
This comment has been minimized.
|
NTS: should be backported to 5-0-stable |
chancancode
added
the
needs backport
label
Feb 15, 2017
chancancode
added this to the 5.0.x milestone
Feb 15, 2017
This was referenced Feb 15, 2017
pushed a commit
that referenced
this pull request
Feb 24, 2017
chancancode
referenced this pull request
Feb 24, 2017
Merged
5-0-stable backports: #27605 & #28013 #28142
added a commit
that referenced
this pull request
Feb 24, 2017
chancancode
removed
the
needs backport
label
Feb 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mtsmfm commentedJan 7, 2017
Rewrite #27550
085546d was reverted (b6ffb5e) because it change the return of
namespaced_pathfrom String to Array.If we create nested (namespaced) rails engine such like bukkits-admin,
bin/rails g scaffold User name:string age:integerwill create
bukkits-admin/app/controllers/bukkits/users_controller.rbbut it should create
bukkits-admin/app/controllers/bukkits/admin/users_controller.rb.In #6643, we changed
namespaced_pathas root pathbecause we supposed application_controller is always in root
but nested rails engine's application_controller will not.