New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI against JRuby 9.1.7.0 #27667

Merged
merged 1 commit into from Jan 14, 2017

Conversation

Projects
None yet
3 participants
@koic
Contributor

koic commented Jan 13, 2017

@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Jan 13, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

rails-bot commented Jan 13, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@eileencodes eileencodes added the JRuby label Jan 13, 2017

@koic

This comment has been minimized.

Show comment
Hide comment
@koic

koic Jan 13, 2017

Contributor

Adding information, JRuby 9.1.7.0 (with "GEM=ap") still fails.

ref: 6197a38

Contributor

koic commented Jan 13, 2017

Adding information, JRuby 9.1.7.0 (with "GEM=ap") still fails.

ref: 6197a38

@eileencodes eileencodes merged commit f2ef515 into rails:master Jan 14, 2017

2 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eileencodes

This comment has been minimized.

Show comment
Hide comment
@eileencodes

eileencodes Jan 14, 2017

Member

Thanks! 👍

Member

eileencodes commented Jan 14, 2017

Thanks! 👍

@koic koic deleted the koic:ci_against_jruby_9_1_7_0 branch Jan 14, 2017

@koic

This comment has been minimized.

Show comment
Hide comment
@koic

koic Jan 14, 2017

Contributor

Thanks too!

Contributor

koic commented Jan 14, 2017

Thanks too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment