Allow SQLServerAdapter To Opt Into A Few Tests #27695

Merged
merged 1 commit into from Jan 16, 2017

Projects

None yet

4 participants

@metaskills
Contributor

Hi! I am the author of the SQLServer adapter for Rails. While working on the long awaited Rails v5 releases, I found a few tests in core that we would like to opt-into.

Our tests run the full ActiveRecord suite and we have a coercion system that enables us to keep most of our changes out of the core test suite. However, these changes open up tests that we do not want to regress on. Willing to answer any questions if needed. Thanks!!!

cc @sgrif

@rails-bot

r? @eileencodes

(@rails-bot has picked a reviewer for you, use r? to override)

@maclover7
Member

@metaskills Looks like there are a few merge conflicts, otherwise looks good 😬

@metaskills metaskills Allow SQLServerAdapter to opt into a few tests.
9848730
@metaskills
Contributor

Whoops, my Rails fork was way behind along with my PR skills. I just resolved the conflict with a proper rebase to upstream master and forced push. Everything appears good now. Thanks @maclover7

@eileencodes eileencodes merged commit 39c1da1 into rails:master Jan 16, 2017

2 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment