Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow SQLServerAdapter To Opt Into A Few Tests #27695
+4
−4
Conversation
This comment has been minimized.
This comment has been minimized.
rails-bot
commented
Jan 16, 2017
|
r? @eileencodes (@rails-bot has picked a reviewer for you, use r? to override) |
rails-bot
assigned
eileencodes
Jan 16, 2017
maclover7
added
the
activerecord
label
Jan 16, 2017
This comment has been minimized.
This comment has been minimized.
|
@metaskills Looks like there are a few merge conflicts, otherwise looks good |
maclover7
added
the
needs work
label
Jan 16, 2017
This comment has been minimized.
This comment has been minimized.
|
Whoops, my Rails fork was way behind along with my PR skills. I just resolved the conflict with a proper rebase to upstream master and forced push. Everything appears good now. Thanks @maclover7 |
eileencodes
merged commit 39c1da1
into
rails:master
Jan 16, 2017
metaskills
referenced this pull request
Jan 16, 2017
Merged
Allow SQLServerAdapter To Opt Into A Few Tests #27703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
metaskills commentedJan 16, 2017
Hi! I am the author of the SQLServer adapter for Rails. While working on the long awaited Rails v5 releases, I found a few tests in core that we would like to opt-into.
Our tests run the full ActiveRecord suite and we have a coercion system that enables us to keep most of our changes out of the core test suite. However, these changes open up tests that we do not want to regress on. Willing to answer any questions if needed. Thanks!!!
cc @sgrif