Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yield array from AC::Parameters#each for block with one arg #27790

Merged
merged 1 commit into from Dec 6, 2017

Conversation

domcleal
Copy link
Contributor

Matches Hash#each behaviour as used in Rails 4.

Other Information

Reproducer: https://gist.github.com/df6296853a73ca3f714174278ec01138 (passes on 4-2-stable, fails on 5-0-stable or master)

Ruby's Hash#each_pair implementation, which also switches on the block arity: https://github.com/ruby/ruby/blob/v2_4_0/hash.c#L1810

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@@ -265,7 +265,12 @@ def to_unsafe_h
# the same way as <tt>Hash#each_pair</tt>.
def each_pair(&block)
@parameters.each_pair do |key, value|
yield key, convert_hashes_to_parameters(key, value)
converted_value = convert_hashes_to_parameters(key, value)
if block.arity == 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can always yield an array since the block will rake care of destructing the array in two argument.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah neat. Thanks, updated and rebased the PR.

Matches Hash#each behaviour as used in Rails 4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants