Yield array from AC::Parameters#each for block with one arg #27790
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
domcleal
force-pushed
the
ac-params-each-yields
branch
from
81c4db7
to
705e197
Compare
| @@ -265,7 +265,12 @@ def to_unsafe_h | |||
| # the same way as <tt>Hash#each_pair</tt>. | |||
| def each_pair(&block) | |||
| @parameters.each_pair do |key, value| | |||
| yield key, convert_hashes_to_parameters(key, value) | |||
| converted_value = convert_hashes_to_parameters(key, value) | |||
| if block.arity == 1 | |||
There was a problem hiding this comment.
We can always yield an array since the block will rake care of destructing the array in two argument.
There was a problem hiding this comment.
Ah neat. Thanks, updated and rebased the PR.
Matches Hash#each behaviour as used in Rails 4.
domcleal
force-pushed
the
ac-params-each-yields
branch
from
705e197
to
d7a121a
Compare
Matches Hash#each behaviour as used in Rails 4.
Other Information
Reproducer: https://gist.github.com/df6296853a73ca3f714174278ec01138 (passes on 4-2-stable, fails on 5-0-stable or master)
Ruby's
Hash#each_pairimplementation, which also switches on the block arity: https://github.com/ruby/ruby/blob/v2_4_0/hash.c#L1810