Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow ActiveRecord::Base.as_json to accept a frozen Hash #27945
ActiveRecord::Base.as_json takes an options Hash, which is cloned. The clone is then modified.
This commit resolves that by changing
There are many situations where one would want to pass a frozen Hash to as_json. I came across this issue when trying to create a default JSON representation:
Doing this in a seemingly innocuous and correct way, I got this stack trace:
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.
Please see the contribution instructions for more information.