Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of ParameterFilter no longer forces `request.filtered_parameters' class to be Hash #27990

Merged
merged 6 commits into from Jun 19, 2017

Conversation

leonelgalan
Copy link
Contributor

Tests

cd actionpack
bundle exec rake
bundle exec ruby -I"lib:test" test/dispatch/request_test.rb

Summary

  • Fixes issue described on Use of ParameterFilter changes request.filtered_parameters class to Hash #27944 - Use of ParameterFilter changes request.filtered_parameters class to Hash
  • filtered_query_string used an Array representation of what semantically is a key value pair: better suited for a Hash. Without this change filtered_params = original_params.class.new returns an Array with unintended consequences.

… class to be Hash

- Fixes issue described on rails#27944
- `filtered_query_string` used an Array representation of what
semantically is a key value pair: better suited for a Hash.  Without
this change `filtered_params = original_params.class.new` returns an
Array with unintended consequences.
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@leonelgalan
Copy link
Contributor Author

Hi @eileencodes, I'm following the guide's advice and giving you a nudge. Let me know if there is anything I can do to help the review/merge process move along.

@rafaelfranca rafaelfranca merged commit 09cb26b into rails:master Jun 19, 2017
rafaelfranca added a commit that referenced this pull request Jun 19, 2017
Use of ParameterFilter no longer forces `request.filtered_parameters' class to be Hash
rafaelfranca added a commit that referenced this pull request Jun 19, 2017
Use of ParameterFilter no longer forces `request.filtered_parameters' class to be Hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants