Remove `encode_special_chars` option from `strip_tags` #28061

Merged
merged 1 commit into from Feb 27, 2017

Conversation

Projects
None yet
5 participants
@andrewhood125
Contributor

andrewhood125 commented Feb 18, 2017

This pr removes the misnomer option encode_special_chars: false from the strip_tags helper.

Fixes: #28060

@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Feb 18, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@Erol

This comment has been minimized.

Show comment
Hide comment
@Erol

Erol Feb 18, 2017

Contributor

strip_tags and strip_links now somewhat sound like a misnomer. WDYT of documenting those two with the additional behavior of encoding special characters?

Contributor

Erol commented Feb 18, 2017

strip_tags and strip_links now somewhat sound like a misnomer. WDYT of documenting those two with the additional behavior of encoding special characters?

@andrewhood125

This comment has been minimized.

Show comment
Hide comment
@andrewhood125

andrewhood125 Feb 18, 2017

Contributor

@Erol I added some docs and examples regarding the behavior let me know what you think and if there is anywhere docs should be updated.

Contributor

andrewhood125 commented Feb 18, 2017

@Erol I added some docs and examples regarding the behavior let me know what you think and if there is anywhere docs should be updated.

@andrewhood125

This comment has been minimized.

Show comment
Hide comment
@andrewhood125

andrewhood125 Feb 27, 2017

Contributor

Updated with master and resolved conflicts in CHANGELOG. I wasn't exactly sure how to handle that. @rafaelfranca what do you think?

Contributor

andrewhood125 commented Feb 27, 2017

Updated with master and resolved conflicts in CHANGELOG. I wasn't exactly sure how to handle that. @rafaelfranca what do you think?

@rafaelfranca

Seems good to me. Could you squash your commits?

@andrewhood125

This comment has been minimized.

Show comment
Hide comment
@andrewhood125

andrewhood125 Feb 27, 2017

Contributor

Squashed. 👍

Contributor

andrewhood125 commented Feb 27, 2017

Squashed. 👍

@rafaelfranca rafaelfranca merged commit 93a33ec into rails:master Feb 27, 2017

2 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@andrewhood125 andrewhood125 deleted the andrewhood125:strip_tags_update branch Feb 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment