[Railties] Add config rake_eager_load

[tjoyal]

Summary

Rake environment disable config.eager_load for from what I understand legacy reasons.

https://github.com/rails/rails/blob/v5.0.1/railties/lib/rails/application.rb#L446

I would wish to be able to control that behaviour so regardless how the application is accessed, the load order remains the same.

I added a new accessor in Rails::Application::Configuration to minimize the diff, but it could be nice to split the mass creation to one per line and 🔡 ?

[guilleiguaran]

👍

[kirs]

Looks as a great path to start towards deprecating the old behaviour 👍

[olivierlacan]

@tjoyal Excellent PR. The legacy reason was bad interaction with rake assets precompile I believe, where a database connection was attempted due to eager loading.

I would make a bigger deal about this in the changelog if I were you since the previous change to make rake task never eager load was a sizable regression that could cause very problematic issues with thread safety in rake tasks.

[olivierlacan]

I would say "class eager_load` behavior" here to avoid potential confusions with ActiveRecord eager loading. I get that we're not in the AR changelog but you never know. :-p

[rafaelfranca]

For now we don't want to advertise this feature too much since it is going to be just a workaround to get it shipped in Rails 5.1 and that will be removed in 5.2. In the long term all the rake tasks will have eager loading disabled and we will give users a mechanism to eager load the tasks they want. We are also going to kill most of the Rake tasks in favor of Rails commands that will respect the configurations.

[seandilda]

What's the current status on this? I'm still seeing eager_load problems with tasks in 5.2

[ghost]

@seandilda - same here, we'd also like eager loading to be configurable in rake tasks

[randoum]

For now we don't want to advertise this feature too much since it is going to be just a workaround to get it shipped in Rails 5.1 and that will be removed in 5.2. In the long term all the rake tasks will have eager loading disabled and we will give users a mechanism to eager load the tasks they want. We are also going to kill most of the Rake tasks in favor of Rails commands that will respect the configurations.

@rafaelfranca Almiost 2 years since this tiny PR is pending. Though it would be very helpful to have it merged. Are you planning to go through this?

[rails-bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.