New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass request params to ActionMailer::Preview #28244

Merged
merged 1 commit into from Apr 27, 2017

Conversation

Projects
None yet
5 participants
@ixti
Contributor

ixti commented Mar 1, 2017

Allows passing query params to email previews:

http://localhost:3000/rails/mailers/user_mailer/password_recovery?email=alice@foobar.com

Second attempt of #25193

@rafaelfranca

Thanks! I'll merge it after the Rails 5.1 branch is created.

@rafaelfranca rafaelfranca added this to the 5.2.0 milestone Mar 1, 2017

@ixti

This comment has been minimized.

Show comment
Hide comment
@ixti

ixti Mar 1, 2017

Contributor

@rafaelfranca Thanks!

Contributor

ixti commented Mar 1, 2017

@rafaelfranca Thanks!

@thinkclay

This comment has been minimized.

Show comment
Hide comment
@thinkclay

thinkclay Apr 26, 2017

The 5.1 branch exists now. Will we see this merged in the next release?

thinkclay commented Apr 26, 2017

The 5.1 branch exists now. Will we see this merged in the next release?

@rafaelfranca rafaelfranca merged commit f680664 into rails:master Apr 27, 2017

2 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ixti ixti deleted the ixti:improve/action-mailer-preview-params branch Apr 27, 2017

@ixti

This comment has been minimized.

Show comment
Hide comment
@ixti

ixti Apr 27, 2017

Contributor

Thanks! 🙇

Contributor

ixti commented Apr 27, 2017

Thanks! 🙇

@khoan

This comment has been minimized.

Show comment
Hide comment
@khoan

khoan Nov 29, 2017

hasn't made it into Rails 5.1.4 yet.

khoan commented Nov 29, 2017

hasn't made it into Rails 5.1.4 yet.

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Nov 29, 2017

Member

This is going to be released in 5.2.0

Member

rafaelfranca commented Nov 29, 2017

This is going to be released in 5.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment