Fix rake db:schema:load with subdirectories
#28287
Merged
+25
−5
Conversation
Related #25174. `db:schema:load` doesn't work with subdirectories like previous `db:migrate:status`. `Migrator.migration_files` should be used in `assume_migrated_upto_version` to fix the issue.
|
@kamipo thanks again! |
|
Thanks too!
On 2017年3月5日(日) at 1:19 Andrew White ***@***.***> wrote:
@kamipo <https://github.com/kamipo> thanks again!
--
Ryuta Kamizono <kamipo@gmail.com>
|
This comment has been minimized.
This comment has been minimized.
Member
pixeltrix
commented on activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb in 031605a
Mar 4, 2017
|
@kamipo what was the reason for making this :nodoc: ? |
This comment has been minimized.
This comment has been minimized.
|
This method is only called via |
This comment has been minimized.
This comment has been minimized.
|
That may be so but it's been public since Rails 2.1 so we shouldn't just make it undocumented - I'll fix it |
This was referenced Apr 26, 2017
kamipo
added a commit
that referenced
this pull request
Jan 19, 2018
This test case which was added in #28287 checks that `ActiveRecord::Schema.define` loads migration versions in subdirectories. It should be kept it as it was.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Related #25174.
db:schema:loaddoesn't work with subdirectories like previousdb:migrate:status.Migrator.migration_filesshould be used inassume_migrated_upto_versionto fix the issue.@pixeltrix Could you also review this?