/rails

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `rake db:schema:load` with subdirectories #28287

Merged
merged 1 commit into from Mar 4, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
3 participants
@kamipo @pixeltrix @maclover7
@kamipo
Member

kamipo commented Mar 4, 2017

Related #25174.

db:schema:load doesn't work with subdirectories like previous
db:migrate:status. Migrator.migration_files should be used in
assume_migrated_upto_version to fix the issue.

@pixeltrix Could you also review this?
@kamipo
Fix `rake db:schema:load` with subdirectories 
Related #25174.

`db:schema:load` doesn't work with subdirectories like previous
`db:migrate:status`. `Migrator.migration_files` should be used in
`assume_migrated_upto_version` to fix the issue.
Loading status checks…
031605a

@pixeltrix pixeltrix merged commit 9852b5a into rails:master Mar 4, 2017
2 checks passed

2 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pixeltrix

This comment has been minimized.

Sign in to view
Member

pixeltrix commented Mar 4, 2017

@kamipo thanks again! 👍
@kamipo

This comment has been minimized.

Sign in to view
Member

kamipo commented Mar 4, 2017

@pixeltrix

This comment has been minimized.

Sign in to view
Member

pixeltrix commented on activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb in 031605a Mar 4, 2017

@kamipo what was the reason for making this :nodoc: ?

This comment has been minimized.

Sign in to view
Member

kamipo replied Mar 4, 2017

This method is only called via AR::Schema.define so I thought that this method is an internal method.

This comment has been minimized.

Sign in to view
Member

pixeltrix replied Mar 4, 2017 •
edited

That may be so but it's been public since Rails 2.1 so we shouldn't just make it undocumented - I'll fix it

@kamipo kamipo deleted the kamipo:fix_db_schema_load branch Mar 4, 2017

@maclover7 maclover7 added the activerecord label Mar 5, 2017

This was referenced Apr 26, 2017

Closed
Closed

kamipo added a commit that referenced this pull request Jan 19, 2018

@kamipo
Restore `test_migrations_status_with_schema_define_in_subdirectories` 
This test case which was added in #28287 checks that
`ActiveRecord::Schema.define` loads migration versions in
subdirectories. It should be kept it as it was.
Loading status checks…
f5c4b7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment