New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select with block doesn't return newly built records in has_many association #28354

Merged
merged 1 commit into from Mar 9, 2017

Conversation

Projects
None yet
3 participants
@kamipo
Member

kamipo commented Mar 9, 2017

The select in QueryMethods is also an enumerable method.
Enumerable methods with block should delegate to records on
CollectionProxy, not scope.

Fixes #28348.

Fix select with block doesn't return newly built records in has_many …
…association

The `select` in `QueryMethods` is also an enumerable method.
Enumerable methods with block should delegate to `records` on
`CollectionProxy`, not `scope`.

Fixes #28348.

@eileencodes eileencodes merged commit c77cbaf into rails:master Mar 9, 2017

2 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kamipo kamipo deleted the kamipo:fix_select_with_block_and_dirty_target branch Mar 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment