I don't think password_confirmation should be a must on all sign ups, if you implement the reset password functionality you don't need to confirm the user's password.
That''s better for a usability point of view since you save time to the user on the sign up, don't make them type more.
has_secure_password with optional password_confirmation
Can you please update the docs as well and include it to your pull request?
More specifically the lines below this one: https://github.com/edgarjs/rails/blob/ede56f1df0ba0039411697744fe0e5764b96ebbb/activemodel/lib/active_model/secure_password.rb#L9
Update doc for password_confirmation => false
Committed, should I create another pull request? or can I update this one?
Figured out. Updated.
Best would be to squash the commits into only 1
Merge branch 'master' of github.com:edgarjs/rails
Sorry, I don't have experience squashing commits. I did it but it merged with the origin, not sure if it's ok.
@edgarjs do it like this: run git rebase -i master. Your editor will open with the list of commits - replace pick with squash before all but the first commit, save, and quit. That should take care of it.
git rebase -i master
hey @dasch, yes I did that, but then it said my branch have diverged, so I needed to do a pull before the push, which caused another merge commit. That's what I'm not sure about how to avoid it.
Now I can't do the squash again, it says:
# Rebase 8d49701..8d49701 onto 8d49701
# p, pick = use commit
# r, reword = use commit, but edit the commit message
# e, edit = use commit, but stop for amending
# s, squash = use commit, but meld into previous commit
# f, fixup = like "squash", but discard this commit's log message
# x, exec = run command (the rest of the line) using shell
# If you remove a line here THAT COMMIT WILL BE LOST.
# However, if you remove everything, the rebase will be aborted.
Sorry about the lack of knowledge in git.
Somehow I did it... need to review the steps and see where I pushed it, because it got to the origin but somehow before the other commits.. or maybe I did something weird. Anyway, here's the single commit: #2879
Sorry for creating another pull request, not found where to remove commits from this one.