Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add `action_controller_base` and `action_controller_api` hooks to mitigate differences between them. Also document Active Support on_load hooks #28402
Active Support allows specific hooks to be called to mitigate loading code from boot time. These hooks include
As evidenced by these issues,
The issue occurs due to the latter having differing implementation and not including methods such as
To mitigate this, implement 2 new hooks
I also noticed the lack of documentation for this topic, so I added a page on it and included the use cases, examples, and list of all available hooks.
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.
Please see the contribution instructions for more information.
Added some grammar comments for the docs. Thanks for the PR!!
Few more grammar comments. Coming along very nicely!!