New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent extra `SET time zone` in `configure_connection` #28413

Merged
merged 1 commit into from Aug 21, 2017

Conversation

Projects
None yet
2 participants
@kamipo
Member

kamipo commented Mar 14, 2017

SET time zone 'value' is an alias for SET timezone TO 'value'.

https://www.postgresql.org/docs/current/static/sql-set.html

So if variables["timezone"] is specified, it is enough to
SET timezone once.

@kamipo kamipo force-pushed the kamipo:prevent_extra_set_time_zone branch Aug 13, 2017

Prevent extra `SET time zone` in `configure_connection`
`SET time zone 'value'` is an alias for `SET timezone TO 'value'`.

https://www.postgresql.org/docs/current/static/sql-set.html

So if `variables["timezone"]` is specified, it is enough to
`SET timezone` once.

@kamipo kamipo force-pushed the kamipo:prevent_extra_set_time_zone branch to fe0fbf4 Aug 21, 2017

@kamipo kamipo merged commit 1b21d95 into rails:master Aug 21, 2017

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kamipo kamipo deleted the kamipo:prevent_extra_set_time_zone branch Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment