Remove -j (--javascript) option from rails new#28546
Merged
rafaelfranca merged 1 commit intorails:masterfrom Mar 27, 2017
Merged
Remove -j (--javascript) option from rails new#28546rafaelfranca merged 1 commit intorails:masterfrom
rails new#28546rafaelfranca merged 1 commit intorails:masterfrom
Conversation
The "-j" option was added 5 years ago (rails@d9c39c3a) when we wanted to support prototype-rails and jquery-rails. Prototype is not as popular and jQuery is not a requirement anymore. Still the "-j" option can be used to install *any* gem that ends in "-rails". This "might" open security issues and does not bring great benefits anymore. If you know which "-rails"-ending gem you want to install, you can manually add it to the Gemfile just like any other gem.
Member
Author
|
My opinion is that we don't need a full deprecation warning cycle for this change, since it only affects generating new apps, not existing apps. Let me know if that's not the case. I looked for |
Contributor
|
It's possible for people to have an app template that includes the option. Perhaps a .railsrc too. Perhaps it's best to deprecate. |
|
I think this makes a lot of sense. It would also alleviate the confusion in my issue created here: #28512 |
Member
|
If they have in the .railsrc it will just be ignored. |
Member
|
I'll include this in 5.1 since we already include rails-ujs. |
rafaelfranca
added a commit
that referenced
this pull request
Mar 27, 2017
Remove -j (--javascript) option from `rails new`
Member
|
Backported in 0b0255d |
rafaelfranca
added a commit
that referenced
this pull request
Mar 27, 2017
Remove -j (--javascript) option from `rails new`
y-yagi
added a commit
to y-yagi/rails
that referenced
this pull request
Mar 28, 2017
Follow up to rails#28546
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "-j" option was added 5 years ago (d9c39c3a)
when we wanted to support prototype-rails and jquery-rails.
Prototype is not as popular and jQuery is not a requirement anymore.
Still the "-j" option can be used to install any gem that ends in "-rails".
This "might" open security issues and does not bring great benefits anymore.
If you know which "-rails"-ending gem you want to install, you can manually
add it to the Gemfile just like any other gem.