Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
FinderMethods#fourty_two docs cite proper source #28598
Silly method gets a silly doc fix,
BUT I'm pretty sure this is some serious Beaudrillard simulacrum, though.
Note: I dug back as far as it seemed reasonable to make sure I wasn't missing something here, but it seems an innocuous-but-still-somewhat-important misunderstanding to correct.
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.
Please see the contribution instructions for more information.
Mar 29, 2017
Aye, thank you for sharing that. It seems the joke went far deeper than I could have imagined, and my research to avoid making a fool of myself was... inadequate. I wish nothing more than to remove myself from this encounter and never speak of it again. It seems I've erroneously allocated my fucks to give.
@wnadeau oh, no problem at all! :)
Your PR was totally fine, it could be the case that the comment was incorrect, and without more information you did what many people would not do, which was to optimistically send a patch, knowing that it could be the case that something else was going on. That by itself is great and thanks for it