New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FinderMethods#fourty_two docs cite proper source #28598

Merged
merged 1 commit into from Mar 29, 2017

Conversation

Projects
None yet
8 participants
@wnadeau
Contributor

wnadeau commented Mar 29, 2017

Silly method gets a silly doc fix,
or I'm missing an even sillier joke and I'm about to get schooled.

BUT I'm pretty sure this is some serious Beaudrillard simulacrum, though.
I'm just doing my part to spread the gospel of Douglas Adams.

Note: I dug back as far as it seemed reasonable to make sure I wasn't missing something here, but it seems an innocuous-but-still-somewhat-important misunderstanding to correct.

FinderMethods#fourty_two docs cite proper source
silly method gets a silly doc fix, 
or I'm missing an even sillier joke and I'm about to get schooled.

BUT I'm pretty sure this is some serious Beaudrillard simulacrum, though.
I'm just doing my part to spread the gospel of Douglas Adams.
@rails-bot

This comment has been minimized.

rails-bot commented Mar 29, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@igneus

This comment has been minimized.

igneus commented Mar 29, 2017

@wnadeau

This comment has been minimized.

Contributor

wnadeau commented Mar 29, 2017

I should probably be explicit to clarify. We are mis-referencing reddit as the source of "42" even being a thing. It's from Douglas Adam's "Hitchhiker's Guide to the Galaxy".

I'm all for the method, just wish it were properly attributed.

@rafaelfranca rafaelfranca merged commit a680a58 into rails:master Mar 29, 2017

2 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fxn

This comment has been minimized.

Member

fxn commented Apr 1, 2017

Yes, that is kinda a meta-joke.

Of course 42 has this known meaning, but it is an irony directed at some convenience API bikeshedding in the early days. The Reddit reference was there on purpose, this doc patch misses the point of the whole thing.

/cc @dhh

@fxn

This comment has been minimized.

Member

fxn commented Apr 1, 2017

For reference, it was introduced here, and the background bikeshedding happened (mainly) in this previous patch and Reddit discussion.

As you can see, "the reddit" is purposeful.

@wnadeau

This comment has been minimized.

Contributor

wnadeau commented Apr 3, 2017

Aye, thank you for sharing that. It seems the joke went far deeper than I could have imagined, and my research to avoid making a fool of myself was... inadequate. I wish nothing more than to remove myself from this encounter and never speak of it again. It seems I've erroneously allocated my fucks to give.

@fxn

This comment has been minimized.

Member

fxn commented Apr 3, 2017

@wnadeau oh, no problem at all! :)

Your PR was totally fine, it could be the case that the comment was incorrect, and without more information you did what many people would not do, which was to optimistically send a patch, knowing that it could be the case that something else was going on. That by itself is great and thanks for it ❤️.

@aguynamedben

This comment has been minimized.

Contributor

aguynamedben commented Apr 3, 2017

I lolled

rafaelfranca added a commit that referenced this pull request Apr 3, 2017

Revert "Merge pull request #28598 from wnadeau/patch-1"
This reverts commit a680a58, reversing
changes made to 842f67d.

Reason: I can't resist to the joke, so better to keep it there
#28598 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment