New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an alias for reverse_merge to with_defaults #28603

Merged
merged 1 commit into from Mar 29, 2017

Conversation

Projects
None yet
6 participants
@mikeastock
Contributor

mikeastock commented Mar 29, 2017

In the context of controller parameters, reverse_merge is commonly used
to provide defaults for user input. Having an alias to reverse_merge
called with_defaults feels more idiomatic for Rails.

Should we add documentation to reverse merge referencing these new aliases?

@rails-bot

This comment has been minimized.

rails-bot commented Mar 29, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rafaelfranca

This comment has been minimized.

Member

rafaelfranca commented Mar 29, 2017

Thank you for the pull request but we want to keep the parameters API as narrow as possible.

@sgrif sgrif reopened this Mar 29, 2017

@sgrif

This comment has been minimized.

Member

sgrif commented Mar 29, 2017

Can you add this to the other places we define reverse_merge as well? (Hash and HashWithIndifferentAccess)

Add aliases for reverse_merge to with_defaults
In the context of controller parameters, reverse_merge is commonly used
to provide defaults for user input. Having an alias to reverse_merge
called with_defaults feels more idiomatic for Rails.

@mikeastock mikeastock force-pushed the mikeastock:alias-reverse-merge branch to 0117810 Mar 29, 2017

@mikeastock

This comment has been minimized.

Contributor

mikeastock commented Mar 29, 2017

@sgrif Added it to both.

@sgrif sgrif merged commit d5a2e8b into rails:master Mar 29, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
codeclimate no new or fixed issues
Details

@mikeastock mikeastock deleted the mikeastock:alias-reverse-merge branch Mar 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment