Fix mistake in JS response parser #28748

Merged
merged 1 commit into from Apr 13, 2017

Conversation

Projects
None yet
5 participants
@DmytroVasin
Contributor

DmytroVasin commented Apr 13, 2017

Summary

Restore ability to accept ecmascript
JS response should not modify DOM.

Steps to reproduce

<%= form_with(url: '/test') do %>
  <%= submit_tag 'submit' %>
<% end %>
# test.js.erb
console.log('bang')

Expected behavior

When we use jquery and jquery_ujs we actually perform string via globalEval and DOMeval, after execution that string is removed

Actual behavior

Actually after evaluating string we can see it at the end of the body tag.

As a side effect of that behavior, we can see that body tag is updated every time when we click submit.

screen shot

System configuration

Rails version:
5.1.0.rc1
Ruby version:
ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-darwin15]

Fix mistake in JS response parser:
  -
  Restore ability to accept ecmascript
  JS response should not modify DOM.
@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Apr 13, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @senny (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @senny (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@DmytroVasin DmytroVasin changed the title from Fix mistake in JS response parser: to Fix mistake in JS response parser Apr 13, 2017

@rafaelfranca rafaelfranca merged commit a84cfe9 into rails:master Apr 13, 2017

2 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

rafaelfranca added a commit that referenced this pull request Apr 13, 2017

Merge pull request #28748 from DmytroVasin/rails-ujs-fix-ajax-respons…
…e-parsing

Fix mistake in JS response parser
@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Apr 13, 2017

Member

Backported in fbb4705

Member

rafaelfranca commented Apr 13, 2017

Backported in fbb4705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment