config.action_controller.perform_caching isn't used anymore in assets pipeline, instead we are using config.assets.digest now
@guilleiguaran we need a test case
we probably already have a test case. we just need to change its configs.
config.action_controller.perform_caching isn't used anymore in assets…
… pipeline, instead we are using config.assets.digest now
I added a test for this part of code, when digest = true Rails.application.assets must be a Sprockets::Index instead of Sprockets::Environment
I think action_controller.perform_caching was correct in this situation.
The Sprockets index is related to caching, and doesn't really have anything to do with digests.
@spohlenz, we added the config.assets.digest just to remove all the references of config.action_controller.perform_caching in asset pipeline:
I'm not sure if removing it entirely is all that necessary IMHO.
The other changes were reasonable because the perform_caching flag was used to control whether digests were added or not. However they're two separate functions and the appropriate configuration variables should be used for each.
perform_caching still makes sense here
We should stop using perform_caching for everything. We should have decoupled options. Those decouples options could have their default value depending on perform_caching, but we do need to have decoupled options.
Then you need to add another option for config.assets.caching.
Enabling sprockets production caching isn't the same thing as flipping digests off and on.
Ancient history now, but 👍 to config.assets.caching to cache the environment (or the reverse, config.assets.reload ?)
Right, the new option was never added and I think this is causing #6803