Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate passing arguments and block at the same time to `count` and `sum` in `ActiveRecord::Calculations` #29262

Conversation

@kamipo
Copy link
Member

@kamipo kamipo commented May 29, 2017

select, count, and sum in Relation are also Enumerable method
that can be passed block. select with block already doesn't take
arguments since 4fc3366. This is follow up of that.

… `sum` in `ActiveRecord::Calculations`

`select`, `count`, and `sum` in `Relation` are also `Enumerable` method
that can be passed block. `select` with block already doesn't take
arguments since 4fc3366. This is follow up of that.
@guilleiguaran guilleiguaran merged commit 109bca9 into rails:master May 29, 2017
2 checks passed
2 checks passed
codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kamipo kamipo deleted the kamipo:deprecate_passing_arguments_with_block_to_count_and_sum branch May 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants