New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace therubyracer with mini_racer #29285

Merged
merged 1 commit into from May 30, 2017

Conversation

Projects
None yet
6 participants
@SamSaffron
Contributor

SamSaffron commented May 30, 2017

therubyracer is a relic, it depends on an ancient version of v8 that has multiple known security vulnerabilities

https://github.com/cowboyd/therubyracer/blob/master/therubyracer.gemspec#L20

In particular this is the equivalent of shipping a dependency to Chrome version 31.

Chrome 31 was released 2013-11-12

All places that talk about therubyracer or include it in templates should be replaced with mini_racer that depends on the most recent version of v8.

per: #29276 (comment)

@rails-bot

This comment has been minimized.

rails-bot commented May 30, 2017

r? @rafaelfranca

(@rails-bot has picked a reviewer for you, use r? to override)

@schneems

Much faster & quite stable.

@vipulnsward

This comment has been minimized.

Member

vipulnsward commented May 30, 2017

I assume this is already compatible with rails maintained sprockets-dependent libs?

@SamSaffron

This comment has been minimized.

Contributor

SamSaffron commented May 30, 2017

Yeah it has been execjs compatible for a very long time.

@guilleiguaran

👍

@guilleiguaran guilleiguaran merged commit 53c8dff into rails:master May 30, 2017

2 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jcoyne added a commit to sul-dlss/was-thumbnail-service that referenced this pull request Sep 6, 2018

Remove therubyracer in favor of nodejs
therubyracer has been abandoned by Rails: rails/rails#29285
It is no longer compatible with the latest version of
autoprefixer-rails: ai/autoprefixer-rails#137

jcoyne added a commit to sul-dlss/sul_pub that referenced this pull request Sep 6, 2018

Remove therubyracer in favor of nodejs
therubyracer has been abandoned by Rails: rails/rails#29285
It is no longer compatible with the latest version of
autoprefixer-rails: ai/autoprefixer-rails#137

peetucket added a commit to sul-dlss/sul_pub that referenced this pull request Sep 7, 2018

Remove therubyracer in favor of nodejs
therubyracer has been abandoned by Rails: rails/rails#29285
It is no longer compatible with the latest version of
autoprefixer-rails: ai/autoprefixer-rails#137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment