Cache: write_multi #29366
Merged
Cache: write_multi #29366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin850
reviewed
Jun 6, 2017
| @@ -521,6 +535,14 @@ def write_entry(key, entry, options) | |||
| raise NotImplementedError.new | |||
| end | |||
|
|
|||
| # Writes an entry to the cache implementation. Subclasses MAY implement | |||
There was a problem hiding this comment.
"Writes several entries to the cache implementation" ?
Rails.cache.write_multi foo: 'bar', baz: 'qux' Plus faster `fetch_multi` with stores that implement `write_multi_entries`. Keys that aren't found may be written to the cache store in one shot instead of separate writes. The default implementation simply calls `write_entry` for each entry. Stores may override if they're capable of one-shot bulk writes, like Redis `MSET`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus faster
fetch_multiwith stores that implementwrite_multi_entries.Keys that aren't found may be written to the cache store in one shot
instead of separate writes.
The default implementation simply calls
write_entryfor each entry.Stores may override if they're capable of one-shot bulk writes, like
Redis
MSET.