Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow prefix/suffix options for store accessors #29373
class SampleModel < ApplicationRecord store :settings, accessors: [:color, :dependencies], coder: JSON has_many :dependencies end
There was a situation where association
We needed SampleModel#dependencies to return the association dependencies (and thus we wanted to add a method like setting_dependencies for JSON dependencies),
But in the end, among stored accessors, only dependencies had
This PR allows this prefix as an option out of the box.
store :settings, accessors: [ :two_factor_auth ], coder: JSON, _prefix: true # => accessor will be model.settings_two_factor_auth store_accessor :settings, :secret_question, _prefix: 'config' # => accessor will be model.config_secret_question store :settings, accessors: [ :login_retry ], _suffix: 'setting' # => accessor will be model.login_retry_setting
Lastly, thank you for the great work, Rails team!
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.
Please see the contribution instructions for more information.
Still relevant in
6.0.0.alpha. I think this is a good idea! See comments for some suggestions