fix url_for when passing a hash to prevent unwanted additional values being added to the hash (backport to 3-0-stable) #2939

Merged
merged 2 commits into from Sep 8, 2011

Projects

None yet

2 participants

@akaspick
Contributor
akaspick commented Sep 8, 2011

This PR is a combination of this original PR...
#2497

And a better fix from this commit...
8196c84#actionpack/lib/action_dispatch/routing/url_for.rb

This PR backports the fix to 3-0-stable using the cleaner solution. This cleaner fix already exists in master and 3-1-stable.

@akaspick akaspick when calling url_for with a hash, additional (likely unwanted) values…
… (such as :host) would be returned in the hash... calling #dup on the hash prevents this
45b7731
@josevalim josevalim merged commit f863af9 into rails:3-0-stable Sep 8, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment