Deprecate an after_bundle callback in Rails plugin templates
#29446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @matthewd (@rails-bot has picked a reviewer for you, use r? to override) |
y-yagi
force-pushed
the
deprecate_after_bundle_in_plugin
branch
from
4e0d259
to
be6a80a
Compare
y-yagi
force-pushed
the
deprecate_after_bundle_in_plugin
branch
from
be6a80a
to
e8eb374
Compare
y-yagi
force-pushed
the
deprecate_after_bundle_in_plugin
branch
from
e8eb374
to
346be6b
Compare
y-yagi
force-pushed
the
deprecate_after_bundle_in_plugin
branch
2 times, most recently
from
59859d2
to
fecf28f
Compare
matthewd
approved these changes
Nov 17, 2017
y-yagi
force-pushed
the
deprecate_after_bundle_in_plugin
branch
from
fecf28f
to
ff30915
Compare
Since fbd1e98, Rails plugin does not run `bundle install` when generating. Therefore, `after_bundle` callback is not actually executed after `bundle`. Since there is a difference between the name and the actual behavior, I think that should be remove.
y-yagi
force-pushed
the
deprecate_after_bundle_in_plugin
branch
from
ff30915
to
632a5f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Since fbd1e98, Rails plugin does not run
bundle installwhen generating.Therefore,
after_bundlecallback is not actually executed afterbundle.Since there is a difference between the name and the actual behavior, I think that should be remove.