Skip to content

Deprecate an after_bundle callback in Rails plugin templates #29446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2017

Conversation

y-yagi
Copy link
Member

@y-yagi y-yagi commented Jun 13, 2017

Since fbd1e98, Rails plugin does not run bundle install when generating.
Therefore, after_bundle callback is not actually executed after bundle.

Since there is a difference between the name and the actual behavior, I think that should be remove.

@rails-bot
Copy link

r? @matthewd

(@rails-bot has picked a reviewer for you, use r? to override)

@y-yagi y-yagi force-pushed the deprecate_after_bundle_in_plugin branch from 4e0d259 to be6a80a Compare June 19, 2017 22:05
@y-yagi y-yagi force-pushed the deprecate_after_bundle_in_plugin branch from be6a80a to e8eb374 Compare June 26, 2017 22:14
@y-yagi y-yagi force-pushed the deprecate_after_bundle_in_plugin branch from e8eb374 to 346be6b Compare July 19, 2017 22:41
@y-yagi y-yagi force-pushed the deprecate_after_bundle_in_plugin branch 2 times, most recently from 59859d2 to fecf28f Compare August 12, 2017 00:41
@y-yagi y-yagi force-pushed the deprecate_after_bundle_in_plugin branch from fecf28f to ff30915 Compare November 17, 2017 23:16
Since fbd1e98, Rails plugin does not
run `bundle install` when generating.
Therefore, `after_bundle` callback is not actually executed after `bundle`.

Since there is a difference between the name and the actual behavior,
I think that should be remove.
@y-yagi y-yagi force-pushed the deprecate_after_bundle_in_plugin branch from ff30915 to 632a5f9 Compare November 18, 2017 01:31
@y-yagi y-yagi merged commit 60c5503 into rails:master Nov 18, 2017
@y-yagi y-yagi deleted the deprecate_after_bundle_in_plugin branch November 18, 2017 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants