Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate an `after_bundle` callback in Rails plugin templates #29446

Merged
merged 1 commit into from Nov 18, 2017

Conversation

@y-yagi
Copy link
Member

@y-yagi y-yagi commented Jun 13, 2017

Since fbd1e98, Rails plugin does not run bundle install when generating.
Therefore, after_bundle callback is not actually executed after bundle.

Since there is a difference between the name and the actual behavior, I think that should be remove.

@rails-bot
Copy link

@rails-bot rails-bot commented Jun 13, 2017

r? @matthewd

(@rails-bot has picked a reviewer for you, use r? to override)

@y-yagi y-yagi force-pushed the y-yagi:deprecate_after_bundle_in_plugin branch Jun 19, 2017
@y-yagi y-yagi force-pushed the y-yagi:deprecate_after_bundle_in_plugin branch Jun 26, 2017
@y-yagi y-yagi force-pushed the y-yagi:deprecate_after_bundle_in_plugin branch Jul 19, 2017
@y-yagi y-yagi force-pushed the y-yagi:deprecate_after_bundle_in_plugin branch 2 times, most recently Aug 8, 2017
@y-yagi y-yagi force-pushed the y-yagi:deprecate_after_bundle_in_plugin branch Nov 17, 2017
Since fbd1e98, Rails plugin does not
run `bundle install` when generating.
Therefore, `after_bundle` callback is not actually executed after `bundle`.

Since there is a difference between the name and the actual behavior,
I think that should be remove.
@y-yagi y-yagi force-pushed the y-yagi:deprecate_after_bundle_in_plugin branch to 632a5f9 Nov 18, 2017
@y-yagi y-yagi merged commit 60c5503 into rails:master Nov 18, 2017
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@y-yagi y-yagi deleted the y-yagi:deprecate_after_bundle_in_plugin branch Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.