Allows for other common redis options to be in cable.yml, by default #29528
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
- Adds RedisAdapterTest::AlternateConfiguration to account for a relatively common alternative setup, as it’s used as the first example in the [Redis rubygem](https://github.com/redis/redis-rb#getting-started) - Supplies original RedisAdapterTest with more complete redis:// url format by adding a ‘userinfo’ (blank user), so that it resembles the alternate configuration - Supplies original EventedRedisAdapterTest with more complete redis:// url as well - Adds before_script to start redis-server with password as a daemon and with explicit defaults copied from the default redis.conf (Instead of using Travis' default init/upstart scripts for `redis` service)
padi
force-pushed
the
actioncable_redis_alt_config_with_password
branch
from
3f40990
to
f55ecc6
Compare
|
@padi avoid to change the assignment of a PR. We use automatic assigns exactly to avoid to load only one person with all the PRs in the organization (that is a lot). If you assign it again to someone just because you see that person is more active you are overloading that person again. |
|
@padi This PR looks to fulfill the needs that I had in my pull request. Can I add the CHANGELOG for you? |
|
@rafaelfranca genuinely sorry about that. I didn't think that one through. @ukblewis glad to help. |
|
Thank you! |
Summary
Previously, the redis adapter for ActionCable accepts only a
:urlas an option. While we can follow the redis url scheme, it is not documented well enough in the Rails Guides.This allows for an alternative setup (that is as common as the previous one) for the redis gem, so people don't occasionally trip up like these. Check the commit message for more technical details.
Other Information
There are other options that can be passed to the Redis gem (See: https://github.com/redis/redis-rb/blob/master/lib/redis/client.rb#L8), but did not include them because:
#cable_configin different context (e.g.driver),path).redis_connectoron intialization, i.e.ActionCable::SubscriptionAdapter::Redis.redis_connector = ->() { initialization_code }Also, I'm not as familiar with setting up
.travis.ymlproperly, you may want to check if what I did was right. I removed instances of the Travis' internalredisservice. Instead, I usedredis-serverusing the default settings + password in thebefore_script. The tests now pass though.Let me know if there's anything else I can do @pixeltrix