Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear screenshots files in tmp:clear task #29534

Merged

Conversation

@y-yagi
Copy link
Member

@y-yagi y-yagi commented Jun 22, 2017

If system test fails, it creates screenshot under tmp/screenshots.

But currently, screenshot files is not cleared by tmp:clear task.
This patch make clears screenshot files in tmp:clear task as well as other tmp files.

@rails-bot
Copy link

@rails-bot rails-bot commented Jun 22, 2017

r? @kaspth

(@rails-bot has picked a reviewer for you, use r? to override)

If system test fails, it creates screenshot under `tmp/screenshots`.
https://github.com/rails/rails/blob/34fe2a4fc778d18b7fe6bdf3629c1481bee789b9/actionpack/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb#L45

But currently, screenshot files is not cleared by `tmp:clear` task.
This patch make clears screenshot files with `tmp:clear` task as well
as other tmp files.
@y-yagi y-yagi force-pushed the clear_screenshots_in_tmp_clear_task branch from 687fddc to 6fbd405 Jun 26, 2017
@eileencodes eileencodes merged commit 6189086 into rails:master Jul 1, 2017
1 of 2 checks passed
@y-yagi y-yagi deleted the clear_screenshots_in_tmp_clear_task branch Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants