Added time helper method freeze_time which is an alias for travel_to Time.now
#29681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sikachu
reviewed
Jul 5, 2017
| # Time.now # => 2017-07-05 11:01:38 +0530 | ||
| # Time.now # => 2017-07-05 11:01:38 +0530 | ||
| def freeze_time | ||
| travel_to Time.now |
There was a problem hiding this comment.
Shouldn't this be Time.current though, just so we can take Time.zone into account?
I wonder if it matters ...
There was a problem hiding this comment.
I went by the existing definition of travel method which uses Time.now.
dhh
reviewed
Jul 5, 2017
| # freeze_time | ||
| # Time.now # => 2017-07-05 11:01:38 +0530 | ||
| # Time.now # => 2017-07-05 11:01:38 +0530 | ||
| def freeze_time |
There was a problem hiding this comment.
Would be nice if this also worked with a block, like travel does.
There was a problem hiding this comment.
@dhh Added support for block as well.
meinac
reviewed
Jul 5, 2017
| @@ -162,4 +162,13 @@ def test_time_helper_travel_with_time_subclass | |||
| assert_equal DateTime.now.to_s, DateTimeSubclass.now.to_s | |||
| end | |||
| end | |||
|
|
|||
| def test_time_helper_freeze_time | |||
There was a problem hiding this comment.
This is not a deterministic test. This can still pass without the correct implementation, you can get same formatted time 3 times.
There was a problem hiding this comment.
Yup, updated the test to be non-deterministic. Please check.
prathamesh-sonpatki
force-pushed
the
freeze-time
branch
2 times, most recently
from
6821dcc
to
f154c45
Compare
prathamesh-sonpatki
force-pushed
the
freeze-time
branch
from
f154c45
to
248749f
Compare
|
Excellent, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
r? @dhh