Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rails secrets:show command #29695

Merged
merged 1 commit into from Jul 8, 2017
Merged

Add rails secrets:show command #29695

merged 1 commit into from Jul 8, 2017

Conversation

@y-yagi
Copy link
Member

@y-yagi y-yagi commented Jul 6, 2017

When secrets confirmed with the secrets:edit command, secrets.yml.enc will change without updating the secrets.

Therefore, even if only want to check secrets, the difference will come out. This is a little inconvenient.
In order to solve this problem, added the secrets:show command. If just want to check secrets, no difference will occur use this command.

@rails-bot
Copy link

@rails-bot rails-bot commented Jul 6, 2017

r? @pixeltrix

(@rails-bot has picked a reviewer for you, use r? to override)

@matthewd
Copy link
Member

@matthewd matthewd commented Jul 6, 2017

I think there may be value in this command anyway, but I think it'd also be worthwhile to fix the underlying issue: if the file is unchanged after secrets:edit, we shouldn't rewrite it.

When secrets confirmed with the `secrets:edit` command, `secrets.yml.enc`
will change without updating the secrets.

Therefore, even if only want to check secrets, the difference will come
out. This is a little inconvenient.

In order to solve this problem, added the `secrets:show` command.
If just want to check secrets, no difference will occur use this command.
@y-yagi y-yagi force-pushed the y-yagi:secrets_show branch to af5368e Jul 6, 2017
@y-yagi
Copy link
Member Author

@y-yagi y-yagi commented Jul 8, 2017

if the file is unchanged after secrets:edit, we shouldn't rewrite it.

Make sense. I fix it with #29705.

@matthewd matthewd merged commit 1990c8f into rails:master Jul 8, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
codeclimate no new or fixed issues
Details
@y-yagi y-yagi deleted the y-yagi:secrets_show branch Jul 8, 2017
bogdanvlviv added a commit to bogdanvlviv/rails that referenced this pull request Mar 13, 2018
- Add a description of major features in Rails 5.2.
- Add a reference to Pull Request/Commit to every entry in CHANGELOGs,
  note that some of them combined.
- Add section "Ruby on Rails Guides" with notable changes.
- Note that
  - Skipped this since encrypted secrets are already on the way out.
    ```
    *   Add `rails secrets:show` command.
        ([Pull Request](rails#29695))
    ```
  - Skipped this since it was backported all the way to 5-0-stable.
    ```
    *   Make Rails' test runner work better with minitest plugins.
        ([Pull Request](rails#29572))
    ```

Thanks to everyone who has been working on Rails 5.2! <3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants