/rails

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `rails secrets:show` command #29695

Merged
merged 1 commit into from Jul 8, 2017

Conversation

Reviewers
No reviews
Assignees

@pixeltrix pixeltrix

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@y-yagi @rails-bot @matthewd @pixeltrix
@y-yagi
Member

y-yagi commented Jul 6, 2017

When secrets confirmed with the secrets:edit command, secrets.yml.enc will change without updating the secrets.

Therefore, even if only want to check secrets, the difference will come out. This is a little inconvenient.
In order to solve this problem, added the secrets:show command. If just want to check secrets, no difference will occur use this command.

@rails-bot rails-bot assigned pixeltrix Jul 6, 2017

@rails-bot

This comment has been minimized.

Sign in to view

rails-bot commented Jul 6, 2017

r? @pixeltrix

(@rails-bot has picked a reviewer for you, use r? to override)
@matthewd

This comment has been minimized.

Sign in to view
Member

matthewd commented Jul 6, 2017

I think there may be value in this command anyway, but I think it'd also be worthwhile to fix the underlying issue: if the file is unchanged after secrets:edit, we shouldn't rewrite it.
@y-yagi
Add `rails secrets:show` command 
When secrets confirmed with the `secrets:edit` command, `secrets.yml.enc`
will change without updating the secrets.

Therefore, even if only want to check secrets, the difference will come
out. This is a little inconvenient.

In order to solve this problem, added the `secrets:show` command.
If just want to check secrets, no difference will occur use this command.
Loading status checks…
af5368e

@y-yagi y-yagi force-pushed the y-yagi:secrets_show branch to af5368e Jul 6, 2017

@y-yagi

This comment has been minimized.

Sign in to view
Member

y-yagi commented Jul 8, 2017

if the file is unchanged after secrets:edit, we shouldn't rewrite it.

Make sense. I fix it with #29705.

@matthewd matthewd merged commit 1990c8f into rails:master Jul 8, 2017
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
codeclimate no new or fixed issues
Details

@y-yagi y-yagi deleted the y-yagi:secrets_show branch Jul 8, 2017

bogdanvlviv added a commit to bogdanvlviv/rails that referenced this pull request Mar 13, 2018

@bogdanvlviv
Update "Ruby on Rails 5.2 Release Notes" Guide [ci skip] 
- Add a description of major features in Rails 5.2.
- Add a reference to Pull Request/Commit to every entry in CHANGELOGs,
  note that some of them combined.
- Add section "Ruby on Rails Guides" with notable changes.
- Note that
  - Skipped this since encrypted secrets are already on the way out.
    ```
    *   Add `rails secrets:show` command.
        ([Pull Request](rails#29695))
    ```
  - Skipped this since it was backported all the way to 5-0-stable.
    ```
    *   Make Rails' test runner work better with minitest plugins.
        ([Pull Request](rails#29572))
    ```

Thanks to everyone who has been working on Rails 5.2! <3
Verified
This commit was signed with a verified signature.
@bogdanvlviv bogdanvlviv Bogdan
GPG key ID: E4ACD76A6DB6DFDD Learn about signing commits
7fd6d69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment