Add rails secrets:show command
#29695
Merged
Conversation
|
r? @pixeltrix (@rails-bot has picked a reviewer for you, use r? to override) |
|
I think there may be value in this command anyway, but I think it'd also be worthwhile to fix the underlying issue: if the file is unchanged after |
When secrets confirmed with the `secrets:edit` command, `secrets.yml.enc` will change without updating the secrets. Therefore, even if only want to check secrets, the difference will come out. This is a little inconvenient. In order to solve this problem, added the `secrets:show` command. If just want to check secrets, no difference will occur use this command.
Make sense. I fix it with #29705. |
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Mar 13, 2018
- Add a description of major features in Rails 5.2.
- Add a reference to Pull Request/Commit to every entry in CHANGELOGs,
note that some of them combined.
- Add section "Ruby on Rails Guides" with notable changes.
- Note that
- Skipped this since encrypted secrets are already on the way out.
```
* Add `rails secrets:show` command.
([Pull Request](rails#29695))
```
- Skipped this since it was backported all the way to 5-0-stable.
```
* Make Rails' test runner work better with minitest plugins.
([Pull Request](rails#29572))
```
Thanks to everyone who has been working on Rails 5.2! <3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
When secrets confirmed with the
secrets:editcommand,secrets.yml.encwill change without updating the secrets.Therefore, even if only want to check secrets, the difference will come out. This is a little inconvenient.
In order to solve this problem, added the
secrets:showcommand. If just want to check secrets, no difference will occur use this command.