Stop creating ApplicationRecord on model generation #29916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eileencodes (@rails-bot has picked a reviewer for you, use r? to override) |
rafaelfranca
requested changes
Jul 24, 2017
| @@ -0,0 +1,24 @@ | |||
| require "rails/generators/active_record" | |||
There was a problem hiding this comment.
Missing frozen string literal comment
lugray
force-pushed
the
stop_generating_application_record
branch
2 times, most recently
from
8895f23
to
45ab73f
Compare
|
Updated. |
lugray
force-pushed
the
stop_generating_application_record
branch
from
45ab73f
to
bdbd5fd
Compare
rafaelfranca
approved these changes
Jul 25, 2017
When generating models, we created ApplicationRecord in the default location if no file existed there. That was annoying for people who moved it to somewhere else in the autoload path. At this point, the vast majority of apps should have either run the upgrade script or generated a model since upgrading. For those that haven't the error message after generating a new model should be helpful: NameError: uninitialized constant ApplicationRecord To ease friction in that case, this also adds a generator for ApplicationRecord.
lugray
force-pushed
the
stop_generating_application_record
branch
from
bdbd5fd
to
75ccdfe
Compare
|
Thanks @lugray! And also thank you for writing an excellent commit message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #29407.
Summary
When generating models, we created ApplicationRecord in the default location if no file existed there. That was annoying for people who moved it to somewhere else in the autoload path. At this point, the vast majority of apps should have either run the upgrade script or generated a model since upgrading. For those that haven't the error message after generating a new model should be helpful:
Other Information
To ease friction in that case, this also adds a generator for ApplicationRecord.