Update String#camelize to provide feedback when a wrong option is sent #30039
Conversation
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
String#camelize was returning nil without any feedback when an invalid option was passed as parameter. This update makes the method to raises an ArgumentError when the option passed is invalid, similar to what Ruby does for String#downcase (and others) in 2.4.1. https://ruby-doc.org/core-2.4.1/String.html#method-i-downcase
1d65185
I think principle of least surprise would have uppercase_first_letter = {upper: true, lower: false}.fetch(first_letter, first_letter)
ActiveSupport::Inflector.camelize(self, uppercase_first_letter) |
hey @lugray I went to Ruby's String docs to learn more of other methods and I think this implementation follows those designs. You can check
|
Summary
String#camelize
was returningnil
without any feedback when aninvalid option was sent as parameter. This update makes the method to
raise an ArgumentError when the option passed is invalid, similar to what
Ruby does for
String#downcase
(and other methods) in 2.4.1.Previously:
Now: