Load Parameters configurations on :action_controller only once

[albertoalmagro]

Summary

This PR fixes the regression where ActionController::UnpermittedParameters exceptions are not being raised.

To accomplish that the following has been made:

• Allow ActiveSupport::LazyLoadHooks to be executed only once.
  Provide run_once: true option to on_load in case you want a hook only to be executed once. This may be useful in cases where executing a hook several times may have undesired side effects. Example: ActiveSupport.on_load(:action_controller, run_once: true)
• Load Parameters configurations on :action_controller only once.
  By using the new ActiveSupport::LazyLoadHooksfunctionality described above fixes regression ActionController::UnpermittedParameters not raised. The inner hook was being executed twice, once when ActionController::Base was loaded and again when ActionController::API was loaded. As options.delete operations inside the block are not idempotent, the second time it was run there was no configuration option available.

Other Information

More information can be found in Issue 30025.

[rails-bot]

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

[rails-bot]

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

[albertoalmagro]

@rafaelfranca @betesh changes done and PR description updated.

[albertoalmagro]

@rafaelfranca @betesh changes done and PR description updated.

[rafaelfranca]

This is great! I made a commend about the implementation that I think can be simpler.

[albertoalmagro]

@rafaelfranca done, I made methods private and rebased. Thanks!

[albertoalmagro]

@rafaelfranca done, I made methods private and rebased. Thanks!

[albertoalmagro]

@kaspth I really like your proposal, I have applied it but changing the method's name to with_execution_control instead of with_once_execution. with_execution_control suggests me that we are doing some control to determine if the hook will be executed or not whereas with_once_execution feels to me like it will always be one single execution.

I have also renamed the option to :run_once because I think it expresses better its intention.

@rafaelfranca please also review last changes.

[albertoalmagro]

@kaspth I really like your proposal, I have applied it but changing the method's name to with_execution_control instead of with_once_execution. with_execution_control suggests me that we are doing some control to determine if the hook will be executed or not whereas with_once_execution feels to me like it will always be one single execution.

I have also renamed the option to :run_once because I think it expresses better its intention.

@rafaelfranca please also review last changes.

[rafaelfranca]

Just to confirm, does the application that you are reproducing this bug has ActionController::Api classes?

[rafaelfranca]

Just to confirm, does the application that you are reproducing this bug has ActionController::Api classes?

[albertoalmagro]

Yes @rafaelfranca , I can confirm it. I have debugged it and I see how the hook is registered for both ActionController::Base and ActionController::API. I have also created a Rails app using this branch and reproduced the bug without using :run_once. After adding :run_once the problem is solved 😄

[albertoalmagro]

Yes @rafaelfranca , I can confirm it. I have debugged it and I see how the hook is registered for both ActionController::Base and ActionController::API. I have also created a Rails app using this branch and reproduced the bug without using :run_once. After adding :run_once the problem is solved 😄

[kaspth]

Where is name coming from here? Previously execute_hook was changed to pass it in.

[albertoalmagro]

Good catch @kaspth I wonder why tests didn't blow up. Since this is merged, please tell me how should I fix it?

[albertoalmagro]

@kaspth I already have a branch to pass the name. Should I open a new PR and reference this one?

[rafaelfranca]

Yes please

[albertoalmagro]

@rafaelfranca @kaspth Done please check PR #30285