Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Load Parameters configurations on :action_controller only once #30045
This PR fixes the regression where ActionController::UnpermittedParameters exceptions are not being raised.
To accomplish that the following has been made:
More information can be found in Issue 30025.
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.
Please see the contribution instructions for more information.
This is great! I made a commend about the implementation that I think can be simpler.
@kaspth I really like your proposal, I have applied it but changing the method's name to
I have also renamed the option to
@rafaelfranca please also review last changes.
Aug 15, 2017
Yes @rafaelfranca , I can confirm it. I have debugged it and I see how the hook is registered for both