New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `binary` helper method to fixtures. #30073

Merged
merged 1 commit into from Aug 14, 2017

Conversation

Projects
None yet
4 participants
@yalab
Contributor

yalab commented Aug 4, 2017

Summary

I want to use binary data as fixture.
I can do it but it is bothered that are needed to encode base64.
So I add the helper method it's so useful.

Thanks

@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Aug 4, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @matthewd (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

rails-bot commented Aug 4, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @matthewd (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Aug 11, 2017

Member

Looks good. Could you add a CHANGELOG entry?

Member

rafaelfranca commented Aug 11, 2017

Looks good. Could you add a CHANGELOG entry?

@yalab yalab changed the title from Added `binary` helper method to fixtures. to Add `binary` helper method to fixtures. Aug 12, 2017

@yalab

This comment has been minimized.

Show comment
Hide comment
@yalab

yalab Aug 12, 2017

Contributor

@rafaelfranca I added CHANGELOG.

Contributor

yalab commented Aug 12, 2017

@rafaelfranca I added CHANGELOG.

@rafaelfranca rafaelfranca merged commit cf91b96 into rails:master Aug 14, 2017

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment