Provide initialization of Active Storage #30101

bogdanvlviv · 2017-08-06T20:59:14Z

rails-bot · 2017-08-06T20:59:16Z

(@rails-bot has picked a reviewer for you, use r? to override)

bogdanvlviv · 2017-08-07T19:19:08Z

After adding Active Storage by default, new apps take up more space.
I got the error Errno::ENOSPC: No space left on device - sendfile on travis-ci(https://travis-ci.org/rails/rails/builds/261890209) and my virtual machine.
The reason that we don't delete a generated app after finishing a test case, I looked at size /tmp and saw that it took up more than 4G space after rails/railties$ bundle exec rake test.
Looks like we must remove a generated app after a test's finishing.

This commit fixes it 02b64f4, but now there is another problem, it takes up more time for execution(https://travis-ci.org/rails/rails/builds/261934074).
Does anyone have any idea?

rafaelfranca · 2017-08-08T22:06:04Z

railties/lib/rails/generators/app_base.rb

      end

      def comment_if(value) # :doc:
-        options[value] ? "# " : ""
+        comment =
+          if value.is_a?(String) || value.is_a?(Symbol)


instead of type check better to check if the class respond to the value

I Agree. Thanks.

rafaelfranca · 2017-08-08T22:07:25Z

railties/lib/rails/generators/rails/plugin/templates/rails/application.rb

 require "action_controller/railtie"
 require "action_view/railtie"
 <%= comment_if :skip_action_mailer %>require "action_mailer/railtie"
 require "active_job/railtie"
 require "active_storage/engine"
-<%= comment_if :skip_action_cable %>require "action_cable/engine"


Why this was removed?

Oops. I missed.

rafaelfranca · 2017-08-11T21:22:04Z

Looking good so far. Could you rebase and fix the tests?

y-yagi · 2017-10-11T05:25:19Z

railties/lib/rails/generators/app_base.rb

+            :skip_sprockets,
+            :skip_action_cable
+          ),
+          skip_active_storage?


I think that specifying skip_active_storage directly is more simpler.

Yeah it is simpler, but I think it is more correctly use skip_active_storage?

y-yagi · 2017-10-11T05:31:12Z

We also need skip_active_storage? check in template of Gemfile.

rails/railties/lib/rails/generators/rails/app/templates/Gemfile

Line 25 in 68a2888

# gem 'mini_magick', '~> 4.8'

y-yagi · 2017-10-11T05:42:28Z

railties/test/isolation/abstract_unit.rb

@@ -153,6 +153,7 @@ def build_app(options = {})

    def teardown_app
      ENV["RAILS_ENV"] = @prev_rails_env if @prev_rails_env
+      FileUtils.rm_rf(tmp_path)


Why was this added?

Intentionally, see description of commit Fix error Errno::ENOSPC: No space left on device - sendfile

bogdanvlviv · 2017-10-11T16:54:25Z

The tests are green!

Thanks @y-yagi

rafaelfranca · 2017-11-06T20:16:13Z

Could you squash the commits?

bogdanvlviv · 2017-11-06T20:48:46Z

@rafaelfranca done

rafaelfranca · 2017-11-06T20:53:33Z

That are still too many commits related to the same change that can be squashed.

…record is used Closes rails#30102 Revert part 787fe90 --skip-active-storage pass throughs `rails plugin new` Add changelog entry about default initialization of Active Storage

bogdanvlviv · 2017-11-06T21:19:09Z

I squashed one more time.

Omit `rails activestorage:install` for jdbcmysql, jdbc and shebang tests AppGeneratorTest#test_config_jdbcmysql_database rails aborted! LoadError: Could not load 'active_record/connection_adapters/mysql_adapter'. Make sure that the adapter in config/database.yml is valid. If you use an adapter other than 'mysql2', 'postgresql' or 'sqlite3' add the necessary adapter gem to the Gemfile. (compressed) bin/rails:4:in `<main>' Tasks: TOP => activestorage:install => environment (See full trace by running task with --trace) AppGeneratorTest#test_config_jdbc_database rails aborted! LoadError: Could not load 'active_record/connection_adapters/jdbc_adapter'. Make sure that the adapter in config/database.yml is valid. If you use an adapter other than 'mysql2', 'postgresql' or 'sqlite3' add the necessary adapter gem to the Gemfile. (compressed) bin/rails:4:in `<main>' Tasks: TOP => activestorage:install => environment (See full trace by running task with --trace) AppGeneratorTest#test_shebang_is_added_to_rails_file /home/ubuntu/.rbenv/versions/2.4.1/bin/ruby: no Ruby script found in input (LoadError) Prevent PendingMigrationError in tests * Run `bin/rails db:migrate RAILS_ENV=test` in test_cases before start tests to prevent PendingMigrationError * FileUtils.rm_r("db/migrate") * --skip-active-storage Fix failed tests in `railties/test/railties/engine_test.rb` Related to rails#30111 Imporve `SharedGeneratorTests#test_default_frameworks_are_required_when_others_are_removed` - Explicitly skip active_storage - Ensure that skipped frameworks are commented - Ensure that default frameworks are not commented Fix error `Errno::ENOSPC: No space left on device - sendfile` Since `rails new` runs `rails active_storage:install` that boots an app. Since adding Bootsnap 0312a5c during booting an app, it creates the cache: 264K tmp/cache/bootsnap-load-path-cache 27M tmp/cache/bootsnap-compile-cache * teardown_app must remove app

… `rails new`

These were added in rails#30101, after rails#31084 it became redundant.

rails-bot assigned kaspth Aug 6, 2017

bogdanvlviv force-pushed the initialization-active_storage branch 3 times, most recently from f71e14d to 989d72e Compare August 7, 2017 04:28

bogdanvlviv changed the title ~~WIP: Provide initialization Active Storage when rails new~~ WIP: Provide initialization Active Storage Aug 7, 2017

bogdanvlviv force-pushed the initialization-active_storage branch 12 times, most recently from c5d740f to 780f237 Compare August 7, 2017 14:01

bogdanvlviv changed the title ~~WIP: Provide initialization Active Storage~~ Provide initialization of Active Storage Aug 7, 2017

bogdanvlviv force-pushed the initialization-active_storage branch from 168fe2f to 8aae5f1 Compare August 7, 2017 16:05

bogdanvlviv force-pushed the initialization-active_storage branch from 02b64f4 to b49509d Compare August 8, 2017 16:06

rafaelfranca reviewed Aug 8, 2017

View reviewed changes

rafaelfranca added this to the 5.2.0 milestone Aug 8, 2017

bogdanvlviv force-pushed the initialization-active_storage branch 2 times, most recently from 4d9b6c5 to 2130d10 Compare August 9, 2017 06:13

bogdanvlviv mentioned this pull request Aug 9, 2017

Improve railties generators tests #30164

Merged

bogdanvlviv force-pushed the initialization-active_storage branch from d11b2b8 to 317a9ba Compare August 11, 2017 16:56

rafaelfranca added the activestorage label Aug 11, 2017

y-yagi reviewed Oct 11, 2017

View reviewed changes

bogdanvlviv force-pushed the initialization-active_storage branch 3 times, most recently from 2e75442 to 8406d91 Compare October 11, 2017 16:00

bogdanvlviv force-pushed the initialization-active_storage branch 6 times, most recently from 69dccd2 to b203d31 Compare November 2, 2017 21:54

bogdanvlviv force-pushed the initialization-active_storage branch from b203d31 to ad81fee Compare November 6, 2017 20:44

Add --skip-active-storage and do so automatically when --skip-active-…

4a835aa

…record is used Closes rails#30102 Revert part 787fe90 --skip-active-storage pass throughs `rails plugin new` Add changelog entry about default initialization of Active Storage

bogdanvlviv force-pushed the initialization-active_storage branch from ad81fee to edf0c95 Compare November 6, 2017 21:13

bogdanvlviv added 3 commits November 6, 2017 21:29

Rails::Generators::Actions#execute_command allows option capture

f4af77a

Execution of active_storage:install should respect --quiet during…

cb8553c

… `rails new`

bogdanvlviv force-pushed the initialization-active_storage branch from edf0c95 to cb8553c Compare November 6, 2017 21:29

rafaelfranca merged commit 63f0c04 into rails:master Nov 6, 2017

bogdanvlviv deleted the initialization-active_storage branch November 6, 2017 22:26

bogdanvlviv mentioned this pull request Nov 8, 2017

Do not run active storage install when bundle install is skipped #31084

Merged

bogdanvlviv added a commit to bogdanvlviv/rails that referenced this pull request Nov 8, 2017

Remove redundant passing --skip-active-storage in test cases

d5ad637

These were added in rails#30101, after rails#31084 it became redundant.

bogdanvlviv mentioned this pull request Nov 8, 2017

Remove redundant passing --skip-active-storage in test cases #31092

Merged

claudiob mentioned this pull request Dec 7, 2017

Run Active Storage migrations in new apps #31315

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide initialization of Active Storage #30101

Provide initialization of Active Storage #30101

bogdanvlviv commented Aug 6, 2017 •

edited

Loading

rails-bot commented Aug 6, 2017

bogdanvlviv commented Aug 7, 2017 •

edited

Loading

rafaelfranca Aug 8, 2017

bogdanvlviv Aug 9, 2017

rafaelfranca Aug 8, 2017

bogdanvlviv Aug 9, 2017

rafaelfranca commented Aug 11, 2017

y-yagi Oct 11, 2017 •

edited

Loading

bogdanvlviv Oct 11, 2017

y-yagi commented Oct 11, 2017

y-yagi Oct 11, 2017

bogdanvlviv Oct 11, 2017

bogdanvlviv commented Oct 11, 2017

rafaelfranca commented Nov 6, 2017

bogdanvlviv commented Nov 6, 2017

rafaelfranca commented Nov 6, 2017

bogdanvlviv commented Nov 6, 2017

Provide initialization of Active Storage #30101

Provide initialization of Active Storage #30101

Conversation

bogdanvlviv commented Aug 6, 2017 • edited Loading

rails-bot commented Aug 6, 2017

bogdanvlviv commented Aug 7, 2017 • edited Loading

rafaelfranca Aug 8, 2017

Choose a reason for hiding this comment

bogdanvlviv Aug 9, 2017

Choose a reason for hiding this comment

rafaelfranca Aug 8, 2017

Choose a reason for hiding this comment

bogdanvlviv Aug 9, 2017

Choose a reason for hiding this comment

rafaelfranca commented Aug 11, 2017

y-yagi Oct 11, 2017 • edited Loading

Choose a reason for hiding this comment

bogdanvlviv Oct 11, 2017

Choose a reason for hiding this comment

y-yagi commented Oct 11, 2017

y-yagi Oct 11, 2017

Choose a reason for hiding this comment

bogdanvlviv Oct 11, 2017

Choose a reason for hiding this comment

bogdanvlviv commented Oct 11, 2017

rafaelfranca commented Nov 6, 2017

bogdanvlviv commented Nov 6, 2017

rafaelfranca commented Nov 6, 2017

bogdanvlviv commented Nov 6, 2017

bogdanvlviv commented Aug 6, 2017 •

edited

Loading

bogdanvlviv commented Aug 7, 2017 •

edited

Loading

y-yagi Oct 11, 2017 •

edited

Loading