Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git_source to Gemfile for plugin generator #30110

Merged
merged 1 commit into from Aug 11, 2017

Conversation

@yhirano55
Copy link
Contributor

@yhirano55 yhirano55 commented Aug 7, 2017

Summary

Missing git_source to Gemfile for rails plugin new generator. So I've fixed it.

@rails-bot
Copy link

@rails-bot rails-bot commented Aug 7, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@yhirano55 yhirano55 force-pushed the yhirano55:add_git_source branch to 59f93bb Aug 8, 2017
@rafaelfranca rafaelfranca merged commit 59f93bb into rails:master Aug 11, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
codeclimate All good!
Details
rafaelfranca added a commit that referenced this pull request Aug 11, 2017
Add git_source to Gemfile for plugin generator
@yhirano55 yhirano55 deleted the yhirano55:add_git_source branch Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants