New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate support of older `config.ru` #30127

Merged
merged 1 commit into from Aug 8, 2017

Conversation

Projects
None yet
4 participants
@y-yagi
Member

y-yagi commented Aug 7, 2017

Since Rails 4.0, config.ru generated by default uses instances of Rails.application. Therefore, I think that it is good to deprecate the old behavior.

Related: #9669

Deprecate support of older `config.ru`
Since Rails 4.0, `config.ru` generated by default uses instances of
`Rails.application`.  Therefore, I think that it is good to deprecate
the old behavior.

Related: #9669
@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Aug 7, 2017

r? @pixeltrix

(@rails-bot has picked a reviewer for you, use r? to override)

rails-bot commented Aug 7, 2017

r? @pixeltrix

(@rails-bot has picked a reviewer for you, use r? to override)

@rafaelfranca rafaelfranca merged commit 21c9c57 into rails:master Aug 8, 2017

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@y-yagi y-yagi deleted the y-yagi:deprecate_support_of_older_config_ru branch Aug 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment