New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `--skip-yarn` option to the plugin generator #30238

Merged
merged 1 commit into from Aug 15, 2017

Conversation

Projects
None yet
5 participants
@bogdanvlviv
Contributor

bogdanvlviv commented Aug 13, 2017

No description provided.

@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Aug 13, 2017

r? @sgrif

(@rails-bot has picked a reviewer for you, use r? to override)

rails-bot commented Aug 13, 2017

r? @sgrif

(@rails-bot has picked a reviewer for you, use r? to override)

Show outdated Hide outdated railties/test/generators/plugin_generator_test.rb
Show outdated Hide outdated railties/test/generators/plugin_generator_test.rb
@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Aug 15, 2017

Member

Could you squash your commits?

Member

rafaelfranca commented Aug 15, 2017

Could you squash your commits?

Add --skip-yarn option to the plugin generator
Add SharedGeneratorTests#application_path
This method will help to DRY in files app_generator_test.rb, plugin_generator_test.rb
@bogdanvlviv

This comment has been minimized.

Show comment
Hide comment
@bogdanvlviv

bogdanvlviv Aug 15, 2017

Contributor

Done!

Contributor

bogdanvlviv commented Aug 15, 2017

Done!

@rafaelfranca rafaelfranca merged commit 692fab2 into rails:master Aug 15, 2017

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bogdanvlviv bogdanvlviv deleted the bogdanvlviv:add-skip_yarn-for-plugin_generator branch Aug 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment