New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump `thor` and `blade` #30288

Merged
merged 1 commit into from Aug 17, 2017

Conversation

Projects
None yet
5 participants
@y-yagi
Member

y-yagi commented Aug 16, 2017

For test with latest thor.

Bump `thor` and `blade`
For test with latest thor.
@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Aug 16, 2017

r? @eileencodes

(@rails-bot has picked a reviewer for you, use r? to override)

rails-bot commented Aug 16, 2017

r? @eileencodes

(@rails-bot has picked a reviewer for you, use r? to override)

y-yagi referenced this pull request Aug 16, 2017

Test with released thor
thor 0.20.0 was released so we can test with the released version.
@yahonda

This comment has been minimized.

Show comment
Hide comment
@yahonda

yahonda Aug 17, 2017

Contributor

I do not think this is a case but usually @rafaelfranca mentions updating Gemfile.lock is not necessary. Refer #28984 (comment) and #30093 (comment)

Contributor

yahonda commented Aug 17, 2017

I do not think this is a case but usually @rafaelfranca mentions updating Gemfile.lock is not necessary. Refer #28984 (comment) and #30093 (comment)

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Aug 17, 2017

Member

In this case I want thor 0.20, so it is fine

Member

rafaelfranca commented Aug 17, 2017

In this case I want thor 0.20, so it is fine

@rafaelfranca rafaelfranca merged commit 9d59193 into rails:master Aug 17, 2017

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@yahonda

This comment has been minimized.

Show comment
Hide comment
@yahonda

yahonda Aug 17, 2017

Contributor

Understood.

Contributor

yahonda commented Aug 17, 2017

Understood.

@y-yagi y-yagi deleted the y-yagi:bump_thor_and_blade branch Aug 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment