Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump thor and blade #30288

Merged
merged 1 commit into from Aug 17, 2017
Merged

Bump thor and blade #30288

merged 1 commit into from Aug 17, 2017

Conversation

@y-yagi
Copy link
Member

@y-yagi y-yagi commented Aug 16, 2017

For test with latest thor.

For test with latest thor.
@rails-bot
Copy link

@rails-bot rails-bot commented Aug 16, 2017

r? @eileencodes

(@rails-bot has picked a reviewer for you, use r? to override)

y-yagi referenced this pull request Aug 16, 2017
thor 0.20.0 was released so we can test with the released version.
@yahonda
Copy link
Contributor

@yahonda yahonda commented Aug 17, 2017

I do not think this is a case but usually @rafaelfranca mentions updating Gemfile.lock is not necessary. Refer #28984 (comment) and #30093 (comment)

@rafaelfranca
Copy link
Member

@rafaelfranca rafaelfranca commented Aug 17, 2017

In this case I want thor 0.20, so it is fine

@rafaelfranca rafaelfranca merged commit 9d59193 into rails:master Aug 17, 2017
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@yahonda
Copy link
Contributor

@yahonda yahonda commented Aug 17, 2017

Understood.

@y-yagi y-yagi deleted the y-yagi:bump_thor_and_blade branch Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants