Support multiple versions arguments for gem method of Generators
#30323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pixeltrix (@rails-bot has picked a reviewer for you, use r? to override) |
y-yagi
reviewed
Aug 19, 2017
| action :gem, "faker", version: [">= 0.1.0", "< 0.3.0"] | ||
|
|
||
| assert_file "Gemfile" do |content| | ||
| assert_match /gem 'rspec', '>= 2\.0\.0\.a5'/, content |
There was a problem hiding this comment.
This will cause Ruby warnings as shown below.
test/generators/actions_test.rb:81: warning: ambiguous first argument; put parentheses or a space even after `/' operator
You need to change like following.
assert_match(/gem 'rspec', '>= 2\.0\.0\.a5'/, content)There was a problem hiding this comment.
@y-yagi Thanks for your comment. I've changed it.
yhirano55
force-pushed
the
support_multiple_version_for_gem_method
branch
from
1bb0d03
to
be49c30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Summary
It seems that
gemmethod is supported only single version.So I've modified it, and added test cases.