New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor SchemaDumper
to make it possible to adapter specific customization
#30337
Conversation
3ce481e
to
c9c8d28
Compare
Thanks for the pull request and update. I'm testing this pull request with Oracle enhanced adapter. So far I need to address "undefined method Let me have some more time to take a look at this pull request. I think I will have some questions. |
All utility methods ( |
Thanks for pointing out. I overlooked that part. Now I have one failure.
Will keep working on it. |
…mization Currently `SchemaDumper` is only customizable for column options. But 3rd party connection adapters (oracle-enhanced etc) need to customizable for table or index dumping also. To make it possible, I introduced adapter specific `SchemaDumper` classes for that.
c9c8d28
to
815dd11
Compare
rsim/oracle-enhanced#1430 resolves all errors, failures and my questions. I think it looks good to me. |
cc @metaskills who maintains ActiveRecord SQL Server Adapter. |
SQL Server Adapter is only customized for column options, so it is easy to follow to this change. |
and abstract `SchemaDumper#extensions` is now an empty method. Since rails#30337, every database adapter has its own `SchemaDumper`. `extensions` are only supported by PostgreSQL database and postgresql database adapter.
Currently
SchemaDumper
is only customizable for column options. But3rd party connection adapters (oracle-enhanced etc) need to customizable
for table or index dumping also. To make it possible, I introduced
adapter specific
SchemaDumper
classes for that.cc @yahonda