Refactor `SchemaDumper` to make it possible to adapter specific customization #30337
Conversation
Thanks for the pull request and update. I'm testing this pull request with Oracle enhanced adapter. So far I need to address "undefined method Let me have some more time to take a look at this pull request. I think I will have some questions. |
All utility methods ( |
Thanks for pointing out. I overlooked that part. Now I have one failure.
Will keep working on it. |
…mization Currently `SchemaDumper` is only customizable for column options. But 3rd party connection adapters (oracle-enhanced etc) need to customizable for table or index dumping also. To make it possible, I introduced adapter specific `SchemaDumper` classes for that.
rsim/oracle-enhanced#1430 resolves all errors, failures and my questions. I think it looks good to me. |
cc @metaskills who maintains ActiveRecord SQL Server Adapter. |
SQL Server Adapter is only customized for column options, so it is easy to follow to this change. |
and abstract `SchemaDumper#extensions` is now an empty method. Since rails#30337, every database adapter has its own `SchemaDumper`. `extensions` are only supported by PostgreSQL database and postgresql database adapter.
Currently
SchemaDumper
is only customizable for column options. But3rd party connection adapters (oracle-enhanced etc) need to customizable
for table or index dumping also. To make it possible, I introduced
adapter specific
SchemaDumper
classes for that.cc @yahonda